Use context.storageUri for logs and support None level
#4071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Configuration
Issue-Enhancement
|
@SeeminglyScience PR to |
andyleejordan
commented
Jul 11, 2022
| @@ -51,7 +51,7 @@ export class PowerShellProcess { | |||
| : ""; | |||
|
|
|||
| this.startPsesArgs += | |||
| `-LogPath '${PowerShellProcess.escapeSingleQuotes(editorServicesLogPath)}' ` + | |||
| `-LogPath '${PowerShellProcess.escapeSingleQuotes(editorServicesLogPath.fsPath)}' ` + | |||
| `-SessionDetailsPath '${PowerShellProcess.escapeSingleQuotes(this.sessionFilePath)}' ` + | |||
There was a problem hiding this comment.
We might want to move sessionFilePath into context.storageUri too. I also need to check if we spawn an instance per workspace or not.
|
I gotta fix now erroneous test assumptions, but that's all I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4067 (and uses the correct location for logs, as reported via Discord, our extension was defaulting to the extension folder which is not where they be stuck).